Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] fix(NcRich*): style fixes and RTL support #6481

Merged
merged 6 commits into from
Jan 31, 2025
Merged

[next] fix(NcRich*): style fixes and RTL support #6481

merged 6 commits into from
Jan 31, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 31, 2025 •
edited by Antreesy
Loading

Backport of #6474

@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components feature: richtext Related to the richtext component RTL Right-to-Left languages support labels Jan 31, 2025
@Antreesy
fix(NcRichText): drop unused props and styles
ce86845 
- we did not support custom classes since component was merged, so should not be breaking

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
(cherry picked from commit f0586ba)
@Antreesy
fix(NcRichText): rearrange styles
3237d7b 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
(cherry picked from commit f083556)
@Antreesy
fix(NcRich*): apply logical rules to Rich components
4d1b4ec 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
(cherry picked from commit 7af98ca)
@Antreesy
fix(NcRich*): decrease size of 'tab' symbol
5ad11ad 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
(cherry picked from commit 738a528)
@Antreesy
fix(NcRichText): increase padding for list items
9067f49 
- closer to native ~40px from user agent

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
(cherry picked from commit bc2ae5a)
@Antreesy Antreesy marked this pull request as ready for review January 31, 2025 15:46
Antreesy
Antreesy approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy
fix(NcRichText): adjust createElement method for Vue3
87b1576 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@susnux susnux merged commit d796386 into next Jan 31, 2025
24 checks passed
@susnux susnux deleted the backport/6474/next branch January 31, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components feature: richtext Related to the richtext component RTL Right-to-Left languages support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @Antreesy