-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcAppNavigation + NcUserBubble + NcRichContenteditable): RTL support #6455
Conversation
But... I did that... 1e5eadd
Not sure that's wise. |
This comment was marked as off-topic.
This comment was marked as off-topic.
It's better to be kept, as it's user input and it will be strange to write in the opposite direction. Also, other apps have auto in the messages input. |
Then it should be handled upstream only if NcRichContenteditable will have a slot for leading / trailing icon. |
0d69357
to
ae7d50e
Compare
src/components/NcAppNavigationCaption/NcAppNavigationCaption.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
ae7d50e
to
ebad174
Compare
/backport to next |
☑️ Resolves
Another issue to keep in mind:
NcRichContenteditable
is used with dir="auto" in Talk and is attached to the div with"_input"
class. While we need to make a space for the emoji picker, the spacing is not adjusted to the RTL direction and it remains on the left side. We probably need to take the padding logic (and others) out of the_input
class and put it in the wrapper classrich-contenteditable
to follow the implemented language direction.🖼️ Screenshots
🏁 Checklist
next
requested with a Vue 3 upgrade