doc: Do not override assets while building the styleguide #6408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
approved these changes
Jan 21, 2025
0c7ac76 to
9381c38
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
9381c38 to
7c29888
Compare
It was a typo by me... Fixed! |
|
I guess this needs a backport to |
|
/backport to next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output directory needs to be different from the input, otherwise the assets are overwritten and we can not use them (e.g. for the avatar).
This needs adjustments in Netlify to use
styleguide/buildfor deployment instead of juststyleguide. @juliusknorr