-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcAvatar): title not shown when component used without menu #6297
fix(NcAvatar): title not shown when component used without menu #6297
Conversation
13b58b5
to
0b20e22
Compare
Thank you for your contribution, @Koc! Engineers with accessibility expertise are probably best to review the change. We've therefore requested their review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6297 +/- ##
=======================================
Coverage 42.30% 42.30%
=======================================
Files 154 154
Lines 3988 3988
Branches 1023 999 -24
=======================================
Hits 1687 1687
- Misses 2190 2193 +3
+ Partials 111 108 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
0b20e22
to
50c8ded
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fixes the issue, but it is not accessible. We should think about an alternative solution (I have no idea at the moment).
/backport to next |
☑️ Resolves
Right now
title
not visible ifNcAvatar
used without menu. This PR fixes that by movingtitle
to parentspan
element.🖼️ Screenshots
🔍 Preview after fix
🏁 Checklist
next
requested with a Vue 3 upgrade