Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcListItem: add tags line and make title ellipsise later #5871

Closed
wants to merge 3 commits into from

Conversation

GVodyanov
Copy link
Contributor

@GVodyanov GVodyanov commented Jul 25, 2024

Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov GVodyanov added the 2. developing Work in progress label Jul 25, 2024
@GVodyanov GVodyanov self-assigned this Jul 25, 2024
@susnux
Copy link
Contributor

susnux commented Jul 29, 2024

I am really not sure if we should extend this component again. It is already a Jack of all trades, so many features for single use cases are merged into it so this component has a very high complexity.
Maybe it would be just better for Mail to use a custom component, that could easily implement the features Mail needs, but no other app.

(writing this as I currently try to fix the component and its about 1k lines for a simple list entry component 👀 )

@ChristophWurst
Copy link
Contributor

If we do a custom component in Mail we have to redo look and feel of the standard list item (like the actions menu that only shows on hover). I'd like to avoid that.

@susnux
Copy link
Contributor

susnux commented Jul 30, 2024

If we do a custom component in Mail we have to redo look and feel of the standard list item (like the actions menu that only shows on hover). I'd like to avoid that.

Well copy paste it and adjust from there? You can drop a lot of stuff, as well as the library variant could drop a lot of stuff.
Currently there are many things in this component only for mail that do not make any / much sense for other apps, like the one line layout or having that many slots for everything you could think of.
In most cases you just need a list entry component which should look consistent, but having a component that can do everything makes maintenance harder.

I mean my comments here are no blockers, it looks well done, but this is more a personal opinion on usability of components :)

Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
@GVodyanov GVodyanov marked this pull request as ready for review July 30, 2024 17:13
@GVodyanov GVodyanov requested a review from hamza221 July 30, 2024 17:13
@GVodyanov
Copy link
Contributor Author

Other fixes:

After Before
Screenshot from 2024-07-30 19-14-18 Screenshot from 2024-07-30 19-15-28

@GVodyanov
Copy link
Contributor Author

No longer needed, see nextcloud/mail#9928 (comment)

@GVodyanov GVodyanov closed this Aug 9, 2024
@ChristophWurst ChristophWurst deleted the enh/add-third-line-list-item branch August 9, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unread style and early ellipsis for envelopes Envelope layout is broken
3 participants