docs: Fix NcAppNavigationCaption examples
#5820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use the real `NcAppNavigation` component as this is injecting other styles. Otherwise the styleguide will look very different to the real result. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
/backport to next |
4 tasks
Antreesy
approved these changes
Jul 18, 2024
| <NcActionButton> | ||
| <template #icon> | ||
| <Plus :size="20" /> | ||
| <div class="styleguide-nc-content"> |
There was a problem hiding this comment.
To mock NcContent:
provide() {
return {
'NcContent:setHasAppNavigation': () => {},
}
},
GVodyanov
approved these changes
Jul 18, 2024
ShGKme
approved these changes
Jul 18, 2024
This was referenced Aug 14, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
We need to use the real
NcAppNavigationcomponent as this is injecting other styles. Otherwise the styleguide will look very different to the real result.🖼️ Screenshots
See especially the padding
🏁 Checklist
nextrequested with a Vue 3 upgrade