Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcReferenceWidget): use requestAnimationFrame in observers #5566

Merged
merged 3 commits into from
May 9, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 8, 2024

Backport of PR #5561

Without `requestAnimationFrame` resize observer causes cypress to crash.

Also use a ref for the width and a computed for the resulting number of lines.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Seems more light weight and also fixes the cypress tests

Also add comments as to why we are using nextTick
in the resizeObserver.

Signed-off-by: Max <max@nextcloud.com>
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews labels May 8, 2024
@susnux susnux merged commit cfc107f into next May 9, 2024
17 checks passed
@susnux susnux deleted the backport/5561/next branch May 9, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants