[next] feat(NcRich*): migrate to vue 3 #4842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
reviewed
Nov 17, 2023
d573d1f to
c5163fc
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
c5163fc to
b0328db
Compare
Antreesy
reviewed
Dec 19, 2023
There was a problem hiding this comment.
Managed to make it work somehow. Please, find patch commits here:
next...feat/2154/rich-patches
| @@ -146,11 +145,11 @@ export default { | |||
| document.body.appendChild(wrapper) | |||
|
|
|||
| // Mount and get raw html | |||
| Item.$mount(mount) | |||
| Item.mount(mount) | |||
| const renderedHtml = wrapper.innerHTML | |||
There was a problem hiding this comment.
Suggested change
| const renderedHtml = wrapper.innerHTML | |
| const renderedHtml = mount.innerHTML |
Thus, you won't pass an extra div wrapper, and mention-bubbles will be pasted as <span /> with display: inline
Another solution is to remove wrapper from this function completely
| ]) | ||
| : null, | ||
| ]) | ||
| }, | ||
| renderMarkdown(h) { | ||
| renderMarkdown() { |
There was a problem hiding this comment.
Method should be modified to parse markdown correctly
| @@ -66,7 +69,7 @@ describe('richEditor.js', () => { | |||
|
|
|||
| it('keeps mentions with user data', () => { | |||
There was a problem hiding this comment.
Regex is outdated, maybe, because of a11y changes
|
Superseded by #4976. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcRich*components to vue 3.Todo:
NcRichTextdoes not work yet and I couldn't figure out why.richEditormixin probably needs to be adjusted.I think a bit of help from the
NcRich*component gurus would be great @juliushaertl @Antreesy