Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EmptyContent Reactivity #3090

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Fix EmptyContent Reactivity #3090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 9 additions & 21 deletions src/components/NcEmptyContent/NcEmptyContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,14 @@ export default {

<template>
<div class="empty-content" role="note">
<div v-if="hasIcon" class="empty-content__icon">
<div v-if="$slots.icon" class="empty-content__icon">
<!-- @slot Optional material design icon -->
<slot name="icon" />
</div>
<h2 v-if="hasTitle" class="empty-content__title">
<!-- @slot Optional title -->
<slot />
{{ title }}
</h2>
<p v-if="hasDescription">
<p v-if="$slots.desc">
<!-- @slot Optional description -->
<slot name="desc" />
</p>
Expand All @@ -92,27 +91,16 @@ export default {
export default {
name: 'NcEmptyContent',

data() {
return {
/**
* Making sure the slots are reactive
*/
slots: this.$slots,
}
props: {
title: {
type: String,
default: '',
},
},

computed: {
hasIcon() {
return this.slots.icon !== undefined
},

hasTitle() {
return this.slots?.default !== undefined
&& this.slots?.default[0]?.text
},

hasDescription() {
return this.slots?.desc !== undefined
return this.title !== ''
},
},
}
Expand Down