-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListItem Design update #3055
ListItem Design update #3055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice! :) 2 questions which are related to ListItem design update:
|
Yes, by default they are. That second example you see in the docs is a special functionality required by mail in which the visibility of the actions is "forced" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me then. :)
@marcoambrosini Mind to rebase and resolve the conflict? :) |
Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com>
Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com>
Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com>
25f3551
to
6498fa1
Compare
Uhh, just saw this effect. Unfortunately, one-line listItems are quite overloaded now. @jancborchardt @marcoambrosini Can we make this optional? So maybe getting the class back, but making the bold-prop default to true? |
@marcoambrosini fix for that at #3136 |
Signed-off-by: Marco Ambrosini marcoambrosini@icloud.com