Skip to content

Commit

Permalink
feat: Refactor NcButton
Browse files Browse the repository at this point in the history
1. Make it a template component instead of a render function
2. Add a `text` prop to allow passing text content as prop
3. Add `noIconAriaHidden` to allow making the icon appear on the accessible tree

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
  • Loading branch information
susnux and ShGKme committed Jan 29, 2025
1 parent 3275634 commit f5df4a7
Show file tree
Hide file tree
Showing 5 changed files with 376 additions and 302 deletions.
4 changes: 2 additions & 2 deletions playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: CC0-1.0
*/
import { defineConfig, devices } from '@playwright/experimental-ct-vue';
import { defineConfig, devices } from '@playwright/experimental-ct-vue'

// Configure projects for major browsers
const projects = [
Expand Down Expand Up @@ -85,4 +85,4 @@ export default defineConfig({
},

projects,
});
})
Loading

0 comments on commit f5df4a7

Please sign in to comment.