Skip to content

Commit

Permalink
fix(NcColorPicker): correct aria-label
Browse files Browse the repository at this point in the history
`aria-label` should be set directly on the element being labelled.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
  • Loading branch information
ShGKme committed Nov 29, 2023
1 parent d9d3e74 commit 79e6885
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/components/NcColorPicker/NcColorPicker.vue
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,11 @@ export default {
:key="index"
:style="{ backgroundColor: color }"
class="color-picker__simple-color-circle"
:class="{ 'color-picker__simple-color-circle--active' : color === currentColor }"
:aria-label="name">
:class="{ 'color-picker__simple-color-circle--active' : color === currentColor }">
<Check v-if="color === currentColor" :size="20" />
<input type="radio"
class="hidden-visually"
:aria-label="name"
:name="`color-picker-${uid}`"
:checked="color === currentColor"
@click="pickColor(color)">
Expand Down

0 comments on commit 79e6885

Please sign in to comment.