-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show loading indicator on file assembling #1458
Show loading indicator on file assembling #1458
Conversation
Bundle ReportChanges will increase total bundle size by 1.37kB (0.17%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1458 +/- ##
=======================================
Coverage ? 27.33%
=======================================
Files ? 14
Lines ? 1489
Branches ? 48
=======================================
Hits ? 407
Misses ? 1082
Partials ? 0 ☔ View full report in Codecov by Sentry. |
5749296
to
c468ae8
Compare
cd20d7f
to
6fe84d3
Compare
Hey, thanks for the PR! Imho, to simplify this, we should :
|
41b71dc
to
7856dae
Compare
@skjnldsv I've did requested changes and updated PR description with new video that shows hot it works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment to help fix the linting, so it's easy to see the actual changes.
If you must add valid lint changes preferable to add in a separate commit.
Looks good-ish though
e88f321
to
4bc4f97
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
4bc4f97
to
701639d
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
701639d
to
06f3802
Compare
@skjnldsv it works worse after latest changes 😿 . Can you please checkout my branch and take a look? Here how can we test it: # remote.php
if ($_SERVER['REQUEST_METHOD'] === 'PUT') {
sleep(3);
} elseif ($_SERVER['REQUEST_METHOD'] === 'MOVE') {
sleep(8);
} Max chunk size is set to 10Mb. I'm uploading 33 + 150 Mb files. |
Hey @Koc let me have a look later. |
Btw, we do support s3 chunk assembling if your s3 backend supports it :) |
|
Background:
We've started using s3 storage instead of local files. And it performs much slower comparing to local filesystem. Now when we upload large file it can took up to 30 seconds for merging chunks into a single file. The problem is there is no any indicator of this activity and users can't understand what happening between progress bar hide and file appears in list.
You can observe how it works after the patch on the video below:
nextcloud-upload-2024-12-08_01.56.49.mp4