feat(files): update mtime on attributes tampering #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b1ce0e to
4f27fcb
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
4f27fcb to
fffd8d8
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #602 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 216 224 +8
Branches 62 62
=========================================
+ Hits 216 224 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Pytal
approved these changes
Apr 10, 2023
d8ba76a to
fffd8d8
Compare
| file.attributes.test = true | ||
|
|
||
| // Check that mtime has been updated | ||
| expect(file.mtime?.getDate()).toBe(new Date().getDate()) |
There was a problem hiding this comment.
this test will fail occasionally if the previous statement runs a microsecond earlier than the next invocation of new Date
There was a problem hiding this comment.
No because I'm comparing the date, so it would have to be exactly 1ms before midnight 😁
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we change an attribute or rename/move a file, the
mtimeshould be edited automaticallymtimecrtime