feat: Make docker integration available for other projects #157

susnux · 2023-02-11T03:48:51Z

Resolves #97

Provide the docker helpers as @nextcloud/cypress/docker import.
Allow installing custom required apps for testing
- Handle text app which is not in the appstore but also not bundled
Allow to auto-detect current app, or set one, and bind mount the directory for testing the app

susnux · 2023-02-11T21:57:44Z

@skjnldsv Added an additional commit fixing the flaky cypress tests by ensuring the user is logged out after the tests.
(because otherwise the session tests fail if they run second).

max-nextcloud · 2023-02-21T14:19:23Z

@skjnldsv Added an additional commit fixing the flaky cypress tests by ensuring the user is logged out after the tests. (because otherwise the session tests fail if they run second).

I think it would be nice to find a different solution there.

If you run a test locally and it fails it's nice to be able to inspect the state of the browser. If the test logs you out in an after block you cannot access the session anymore. Cypress docs also have a section about this.

I'm happy to brainstorm alternative solutions or try out some things.

susnux · 2023-02-21T17:26:48Z

@max-nextcloud I changed it to before hooks as suggested on that page from the cypress documentation, seems to work fine :)

cypress.config.ts

cypress/e2e/sessions.cy.ts

cypress/e2e/users.cy.ts

lib/docker.ts

package.json

rollup.config.mjs

codecov · 2023-07-06T01:29:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d1a7a0) 96.47% compared to head (e008cf6) 96.47%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files           5        5           
  Lines          85       85           
  Branches        4        4           
=======================================
  Hits           82       82           
  Misses          3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

skjnldsv · 2023-07-07T05:54:16Z

You seem to be doing some changes still, so I set it to 2. developing, please ping again when/if ready :)

lib/docker.ts

susnux · 2023-10-25T22:47:09Z

Anything I need to do here? :)
Would be great if we can reuse it in apps (then I maybe have motivation to add Cypress to forms 😆 )

skjnldsv · 2023-10-26T07:01:26Z

README.md

+				.then(waitOnNextcloud)
+				// configure Nextcloud, also install and enable the `viewer` app
+				.then(() => configureNextcloud(['viewer']))


How can I mount the local Viewer if I'm running Cypress in https://github.com/nextcloud/viewer though?

Edit: No just leave it as it is, because viewer is mounted (as it is the app, see startNextcloud).
Then later on in configureNextcloud it checks for the app to be preset locally first and will detect the local viewer and enable it.

~~As this is your target app it will be mounted automatically, but as viewer is installed by default you need to make sure to disable mounting of the vendored one~~

So, I can't use this configureNextcloud and have to keep mine?

what do you mean? If you want to test the local viewer you do not need to adjust anything simply do as the readme says and the local viewer will be used

Aaaah, if you specify it, it will not be cloned with git.
I didn't realized that. I think the jsdoc could reflect that,

I updated the jsdocs here to reflect this.

max-nextcloud

Tested this when adding cypress tests to the data_request app here: nextcloud/data_request#197. Works like a charm 🪄

Also replaced the imports in the viewers cypress.config.js and it runs fine.

Thanks a lot for making this available to everyone! ❤️

* Provide the docker helpers as `@nextcloud/cypress/docker` import. * Allow installing custom required apps for testing * Handle `text` app which is not in the appstore but also not bundled * Allow to autodetect current app, or set one, and bind mount the directory for testing the app Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>

Vendored apps are apps which are not provided with the appstore but released with the server, for the shallow server those apps have to be cloned. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>

Signed-off-by: Max <max@nextcloud.com>

From my point of view everything was addressed.

susnux added enhancement New feature request 2. developing Work in progress labels Feb 11, 2023

susnux force-pushed the feat/docker-node branch from 0c2f19d to f0eb9c7 Compare February 11, 2023 12:56

susnux requested a review from skjnldsv February 11, 2023 21:55

susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 11, 2023

susnux force-pushed the feat/docker-node branch from 30c853d to 5d775fb Compare February 11, 2023 21:57

susnux requested review from juliusknorr and max-nextcloud February 21, 2023 13:11

susnux force-pushed the feat/docker-node branch from 5d775fb to 6a803e0 Compare February 21, 2023 17:20

skjnldsv previously requested changes Mar 1, 2023

View reviewed changes

skjnldsv mentioned this pull request Mar 3, 2023

fix: Make sure sessions are cleared between tests #168

Merged

skjnldsv force-pushed the feat/docker-node branch from 6a803e0 to f0eb9c7 Compare March 3, 2023 09:10

susnux force-pushed the feat/docker-node branch from f0eb9c7 to 4e3b9f4 Compare July 6, 2023 01:28

susnux force-pushed the feat/docker-node branch from 4e3b9f4 to 30026bb Compare July 6, 2023 02:42

susnux requested a review from skjnldsv July 6, 2023 02:43

susnux force-pushed the feat/docker-node branch from 30026bb to 0075359 Compare July 7, 2023 01:24

skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 7, 2023

susnux added 3. to review Waiting for reviews 2. developing Work in progress and removed 2. developing Work in progress 3. to review Waiting for reviews labels Jul 7, 2023

susnux force-pushed the feat/docker-node branch from 0075359 to 800a1ac Compare October 23, 2023 03:00

susnux removed the 2. developing Work in progress label Oct 23, 2023

susnux added the 3. to review Waiting for reviews label Oct 23, 2023

susnux force-pushed the feat/docker-node branch from 800a1ac to f5be501 Compare October 23, 2023 03:05

skjnldsv reviewed Oct 24, 2023

View reviewed changes

lib/docker.ts Show resolved Hide resolved

susnux force-pushed the feat/docker-node branch from f5be501 to 31a461f Compare October 24, 2023 11:42

skjnldsv reviewed Oct 26, 2023

View reviewed changes

max-nextcloud requested a review from skjnldsv January 2, 2024 11:16

max-nextcloud mentioned this pull request Jan 4, 2024

test(cy): initial cypress tests nextcloud/data_request#197

Merged

5 tasks

max-nextcloud approved these changes Jan 4, 2024

View reviewed changes

susnux and others added 3 commits January 4, 2024 08:58

fix: Add more vendored apps

754bdfa

Vendored apps are apps which are not provided with the appstore but released with the server, for the shallow server those apps have to be cloned. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>

docs(docker): clarify mounted app under development is used

e008cf6

Signed-off-by: Max <max@nextcloud.com>

max-nextcloud force-pushed the feat/docker-node branch from 6cab418 to e008cf6 Compare January 4, 2024 07:59

max-nextcloud enabled auto-merge January 4, 2024 08:01

max-nextcloud merged commit c35a40d into master Jan 4, 2024
10 of 11 checks passed

max-nextcloud deleted the feat/docker-node branch January 4, 2024 08:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Make docker integration available for other projects #157

feat: Make docker integration available for other projects #157

susnux commented Feb 11, 2023

susnux commented Feb 11, 2023

max-nextcloud commented Feb 21, 2023

susnux commented Feb 21, 2023

codecov bot commented Jul 6, 2023 •

edited

Loading

skjnldsv commented Jul 7, 2023

susnux commented Oct 25, 2023

skjnldsv Oct 26, 2023

susnux Oct 26, 2023 •

edited

Loading

skjnldsv Oct 26, 2023

susnux Oct 31, 2023

skjnldsv Nov 1, 2023

max-nextcloud Jan 2, 2024

max-nextcloud left a comment

feat: Make docker integration available for other projects #157

feat: Make docker integration available for other projects #157

Conversation

susnux commented Feb 11, 2023

susnux commented Feb 11, 2023

max-nextcloud commented Feb 21, 2023

susnux commented Feb 21, 2023

codecov bot commented Jul 6, 2023 • edited Loading

Codecov Report

skjnldsv commented Jul 7, 2023

susnux commented Oct 25, 2023

skjnldsv Oct 26, 2023

Choose a reason for hiding this comment

susnux Oct 26, 2023 • edited Loading

Choose a reason for hiding this comment

skjnldsv Oct 26, 2023

Choose a reason for hiding this comment

susnux Oct 31, 2023

Choose a reason for hiding this comment

skjnldsv Nov 1, 2023

Choose a reason for hiding this comment

max-nextcloud Jan 2, 2024

Choose a reason for hiding this comment

max-nextcloud left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 6, 2023 •

edited

Loading

susnux Oct 26, 2023 •

edited

Loading