Add fauna adapter #686
Add fauna adapter #686
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/6tjdie1pu |
| if (new Date() > dateSessionIsDueToBeUpdated) { | ||
| const newExpiryDate = new Date() | ||
| newExpiryDate.setTime(newExpiryDate.getTime() + sessionMaxAge) | ||
| session.expires = newExpiryDate |
There was a problem hiding this comment.
Shouldn't this be?
session.expires = newExpiryDate.valueOf()
If not fauna just stores an empty object (at least that's what I've been getting)
There was a problem hiding this comment.
The logic is kept in sync with other adapters: https://github.com/nextauthjs/next-auth/tree/main/src/adapters
Let me check why fauna isn't saving this
| ? appOptions.session.maxAge * 1000 | ||
| : defaultSessionMaxAge | ||
| const sessionUpdateAge = | ||
| appOptions && appOptions.session && appOptions.session.updateAge |
There was a problem hiding this comment.
Noticed this while testing with 0, was using the default.
appOptions && appOptions.session && (appOptions.session.updateAge || appOptions.session.updateAge === 0)
There was a problem hiding this comment.
The logic is kept in sync with other adapters: https://github.com/nextauthjs/next-auth/tree/main/src/adapters
Can you raise an issue for this?
There was a problem hiding this comment.
checked master, and both prisma and typeorm adapters have the right logic (fallback to 0).
Am I missing something here?
const sessionUpdateAge = (appOptions && appOptions.session && appOptions.session.updateAge)
? appOptions.session.updateAge * 1000
: 0
| async function createUser (profile) { | ||
| console.log('-----------createUser------------') | ||
| // console.log(profile); | ||
| return faunaWrapper( |
There was a problem hiding this comment.
I'm not sure if this is a pattern with fauna (new user as well) but to use the ref's across the other methods I basically return:
return await faunaClient.query(q.Create(q.Collection('users'), { data: profile }))
.then(res => { return { ...res.data, id: res.ref } })
This way further down on other methods like getUser, I can directly use the id as follows:
async function getUser (id) {
try {
return await faunaClient
.query(q.Get(q.Ref(id)))
.then(res => { return { ...res.data, id: res.ref } })
.catch(err => Promise.resolve(null))
} catch (error) {
return Promise.reject(new Error('GET_USER_ERROR'), error)
}
}
There was a problem hiding this comment.
It is a fauna pattern. It's optimal to use FQL way to execute multiple operations instead of using js patterns.
There was a problem hiding this comment.
maybe it wasn't clear because of the line # of the comment, but I wasn't referring to the faunaWrapper. I was referring to the q.Select('data' part ... by returning the ref object as well, I was able to use the fauna IDs directly (Ref) rather than creating yet another set of id: fields for each object.
Which I'm not sure if fauna encourages that or encourages devs to handle their own IDs.
There was a problem hiding this comment.
You are correct. We can directly use fauna ID but I just want to have id field with uuid so that I can simply extract the 'data' part of the document in case of migration to other db.
|
Hi guys, tentative Fauna support was merged from PR #708 as that had tests and a few users who'd already used and vouched for the implementation. We still need some docs re: Fauna, and any other PRs improving the support or tests are always welcome as well! |
|
@ndom91 thanks for the update, closing this. |
@LoriKarikari
Adding faunadb adapter #682