-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(adapter) - fix cookie expiration in Fauna getSession #1134
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/ailghk2a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are linting errors, could you fix those at least so builds don't fail? :) @pbteja1998
…etting the session from db
c3bd1aa
to
9871510
Compare
So sorry for this @pbteja1998, but we decided to drop builtin support for Fauna DB for now. it will be removed soon in a later release. it is a bit of an overhead to make sure it works, while there aren't even tests for it. As you did as well so good, it is still possible to use it with the custom adapter option. 😉 |
Not a problem. It works for my use-case. So it's OK. |
Fixes #1131
What:
session.data.expires
that we get from Fauna DB is inFauna.Time
format. In this PR, I am converting it into milliseconds.Why:
Session not being persisted when browser is closed because of invalid
expiresAt
dateChecklist: