Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix winston-esm versioned tests #1898

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

jsumners-nr
Copy link
Contributor

The tests from #1894 exhibited a failure case when the versioned sampling was expanded in the main CI suite (https://github.com/newrelic/node-newrelic/actions/runs/7091603183/job/19301106334). The issue is that Winston changes the way they export their API between v3.3.4 and v3.4.0 in winstonjs/winston#2006. This PR narrows the test case to test against Winston >= 3.4.0.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31dc717) 96.87% compared to head (65910df) 96.88%.
Report is 1 commits behind head on main.

❗ Current head 65910df differs from pull request most recent head 55bef12. Consider uploading reports for the commit 55bef12 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1898   +/-   ##
=======================================
  Coverage   96.87%   96.88%           
=======================================
  Files         209      209           
  Lines       39774    39863   +89     
=======================================
+ Hits        38533    38622   +89     
  Misses       1241     1241           
Flag Coverage Δ
integration-tests-16.x 78.69% <46.77%> (-0.06%) ⬇️
integration-tests-18.x 78.96% <46.77%> (-0.07%) ⬇️
integration-tests-20.x 78.98% <46.77%> (-0.06%) ⬇️
unit-tests-16.x 90.88% <60.00%> (-0.10%) ⬇️
unit-tests-18.x 90.86% <60.00%> (-0.10%) ⬇️
unit-tests-20.x 90.86% <60.00%> (-0.10%) ⬇️
versioned-tests-16.x 73.78% <100.00%> (+0.03%) ⬆️
versioned-tests-18.x 73.78% <100.00%> (+0.03%) ⬆️
versioned-tests-20.x 73.79% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr marked this pull request as ready for review December 4, 2023 20:21
@jsumners-nr jsumners-nr requested a review from bizob2828 December 4, 2023 20:50
@bizob2828 bizob2828 merged commit 6e02e57 into newrelic:main Dec 4, 2023
@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Dec 4, 2023
@jsumners-nr jsumners-nr deleted the fix-versioned-tests branch December 6, 2023 13:49
@github-actions github-actions bot mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants