Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v9.7.1 #1449

Merged
merged 5 commits into from
Dec 6, 2022
Merged

Release v9.7.1 #1449

merged 5 commits into from
Dec 6, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 5, 2022

Proposed Release Notes

  • Reintroduced throttling during reading of instrumented application's dependency tree during startup, to prevent EMFILE issues.

  • Improved Restify support

    • Added a new test stanza to run restify >=10 on Node 18.
    • Update our versioned tests to support Restify 9.0.0.
  • Laid foundation for supporting Code Level Metrics via Codestream. Note that this integration is not fully finished and should not be used.

  • Improved the readability and maintainability of agent by reducing the Cognitive Complexity of various aspects of the agent.

  • Added newrelic.noticeError() example to our API docs.

  • Upgraded @grpc/grpc-js from 1.6.9 to 1.7.3.

  • Upgraded @grpc/proto-loader from 0.6.13 to 0.7.3.

  • Removed async from benchmark tests, fixed failing benchmark suites, and removed deprecated suite.

Links

Details

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2022

CLA assistant check
All committers have signed the CLA.

@jmartin4563 jmartin4563 closed this Dec 5, 2022
@jmartin4563 jmartin4563 reopened this Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1449 (b87add6) into main (9c508a5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1449   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files         196      196           
  Lines       37918    37918           
  Branches       23       23           
=======================================
  Hits        36540    36540           
  Misses       1378     1378           
Flag Coverage Δ
esm-unit-tests-14.x 47.57% <ø> (ø)
esm-unit-tests-16.x 92.14% <ø> (ø)
esm-unit-tests-18.x 92.14% <ø> (ø)
integration-tests-14.x 77.60% <ø> (ø)
integration-tests-16.x 77.71% <ø> (+0.01%) ⬆️
integration-tests-18.x 77.70% <ø> (ø)
unit-tests-14.x 90.17% <ø> (ø)
unit-tests-16.x 90.24% <ø> (ø)
unit-tests-18.x 90.22% <ø> (ø)
versioned-tests-14.x 75.08% <ø> (ø)
versioned-tests-16.x 76.45% <ø> (ø)
versioned-tests-18.x 76.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmartin4563 jmartin4563 marked this pull request as ready for review December 5, 2022 18:21
NEWS.md Outdated

### v9.7.1 (2022-12-05)

* Reintroduced throttled reading of dependency tree at startup to prevent EMFILE issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds pretty jargony. Is there or should there be a clearer explanation of this? What dependency tree? What throttled reading?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Reintroduced throttling during reading of instrumented application's dependency tree during startup, to prevent EMFILE issues.

I don't know that we'd need to specify where and how we're throttling.

NEWS.md Outdated

* Removed deprecated and failing suites from benchmark tests.

* Updated code coverage to upload all reports at end of CI run.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably another bullet point item that is too noisy for release notes.

NEWS.md Outdated
* Added a new test stanza to run restify >=10 on Node 18.
* Update our versioned tests to support Restify 9.0.0.

* Enhanced agent to lay foundation for supporting for Code Level Metrics via Codestream. Note that while changes have been made to the agent for [Codestream](https://docs.newrelic.com/docs/codestream/how-use-codestream/performance-monitoring/), this integration is not fully finished and should not be used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just

Laid foundation for supporting Code Level Metrics via [Codestream](https://docs.newrelic.com/docs/codestream/how-use-codestream/performance-monitoring/). Note that this integration is not fully finished and should not be used.

NEWS.md Outdated

* Upgraded @grpc/proto-loader from 0.6.13 to 0.7.3.

* Removed deprecated and failing suites from benchmark tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I'd say

Removed async from benchmark tests, fixed failing benchmark suites, and removed deprecated suite.

mrickard
mrickard previously approved these changes Dec 5, 2022
jordigh
jordigh previously approved these changes Dec 5, 2022
@jmartin4563 jmartin4563 dismissed stale reviews from jordigh and mrickard via b87add6 December 6, 2022 13:47
@jmartin4563 jmartin4563 merged commit 8f4f379 into main Dec 6, 2022
@jmartin4563 jmartin4563 deleted the release/v9.7.1 branch December 6, 2022 14:05
@github-actions github-actions bot mentioned this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants