-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 9.12.0 #2769
Merged
Merged
Release 9.12.0 #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a manual port value can be passed to the security agent when needed
update description for security.applicationinfo.port
- introduce NewRelic::Control::SecurityInterface singleton class - leverage the singleton class to ensure the security agent is only ever initialized once - leverage the singleton class to defer security agent initialization in lockstep with dependency detection deference - have each singleton class perform its own `require` of the singleton library so that it's not necessary to understand that the library is coming in from the `Control` class that might seem to have nothing to do with the singleton class
- update NewRelic::Control::Security source file with license header and frozen string literal magic comment - remove commented out dev dependency from gemspec, as Gemfile will be used
NewRelic::Control::SecurityInterface
remove blank line left over from testing to cut down on diff noise
initialize the instance vars
SecurityInterface: Ruby <= 2.4 compatibility
make sure the SecurityInterface singleton behaves as expected
K2 security interface tests
when relying on the 3 argument version of `stub`, make sure it's available
security interface tests: skip MiniTest 4
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
add a security agent note, update descriptions further
reconcile .rb and .yml changes from the PR
updated security config: application_info
make it abundantly clear which combinations of the 3 options will disable the security agent
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
Re-enable Rails EDGE CI testing, address Rails v8.0-alpha specific issues
Run url test only on its own
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
Integration of Newrelic Ruby Security agent
Co-authored-by: James Bunch <fallwith@gmail.com>
Prerelease 9.12.0-pre
Co-authored-by: Prateek Sen <33506953+prateeksen@users.noreply.github.com>
Add newrelic_security gem to changelog
Previously, config descriptions were edited to adhere to a 120 character line length. This caused problems for some descriptions when the newrelic.yml file was generated. The newrelic.yml task handles its own line lengths. We should revisit this another time.
Revert spacing changes
* Add Security Agent to config.rake
Add security agent content back to newrelic.yml
SimpleCov Report
|
kaylareopelle
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated PR for 9.12.0 release