Refactor local_environment methods

[fransan6]

Overview

Cleaned up methods to replace single if statements with early returns.

Ran bundle exec rake and there were 0 failures and 0 errors 🌈 (just 5 skips, which I had when I ran the command before refactoring).

Resolves #2388

I wasn't sure if the check_for_thin method (line 173 old, 175 new) could be refactored as it seemed that the NewRelic::LanguageSupport.object_space_usable? if-else returned @discovered_dispatcher = :thin either way. But I'm a beginner so I am sure the if-else is needed as is! Wanted to flag though, just in case.

Reviewer Checklist

• Perform code review
• Add performance label
• Perform appropriate level of performance testing
• Confirm all checks passed
• Add version label prior to acceptance

[CLAassistant]

All committers have signed the CLA.

[fallwith]

These changes look great, fransan6, thank you!