Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix: Rails40 and Rails41 #2018

Merged
merged 11 commits into from
May 17, 2023
Merged

CI fix: Rails40 and Rails41 #2018

merged 11 commits into from
May 17, 2023

Conversation

hannahramadan
Copy link
Contributor

@hannahramadan hannahramadan commented May 17, 2023

Rails40 and Rails41 failed the CI due to an installation error of the mysql2 gem. When moving to agent v9.0, some bundler configuration code was ripped out that looked like it was only needed for rubies 2.2. and 2.3, but was also being used for 2.4. This method has been added back. And older version of Rack was also needed to properly run.

@github-actions
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.99% 93%
Branch 85.53% 85%

@hannahramadan hannahramadan changed the title Use latest mysql2 CI fix: Rails40 and Rails41 May 17, 2023
@hannahramadan hannahramadan marked this pull request as ready for review May 17, 2023 21:40
@hannahramadan hannahramadan merged commit 1908835 into dev May 17, 2023
@hannahramadan hannahramadan deleted the mysql2_rails4 branch May 17, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants