Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rackup >=2.0.0 #2017

Merged
merged 4 commits into from
May 16, 2023
Merged

Use rackup >=2.0.0 #2017

merged 4 commits into from
May 16, 2023

Conversation

hannahramadan
Copy link
Contributor

@hannahramadan hannahramadan commented May 16, 2023

We need to require rackup when using rack >=v3.

The Rackup v1.0.0 release was missing an important file, Rackup v2.0.0 was released the same day with the fix. We should only ever use Rackup >=v2.0.0

@github-actions
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.99% 93%
Branch 85.53% 85%

@hannahramadan hannahramadan marked this pull request as ready for review May 16, 2023 19:10
@hannahramadan hannahramadan changed the title pin grape Use rackup >=2.0.0 May 16, 2023
@hannahramadan hannahramadan merged commit 3f82a0d into dev May 16, 2023
@hannahramadan hannahramadan deleted the ci_down_grape branch May 19, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants