Flask v2 Support #242
Merged
Flask v2 Support #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add testing for nested blueprints. * Remove comment in tox.ini. * Add pytest xfails for broken exception handling tests. * Add flask version checks for nested blueprints.
* Update error handler instrumentation point for flask v2. * Reformat framework_flask.py file. * Remove pytest xfails. * Remove outdated flask versioning checks in tests,
* Flask async view testing * Add skip logic for older versions of flask * Merge skip logic together for blueprints * Fix extras on master branch for flask * Remove old flask version skip logic
* Restore required flask version testing * Fix version python 2 syntax issues * Remove py36 from latest flask tests
umaannamalai
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
Related Github Issue
Closes #243
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
For most contributions it is strongly recommended to add additional tests which
exercise your changes.