Skip to content

Commit

Permalink
Fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
hmstepanek committed Jan 31, 2025
1 parent 18891f1 commit 05af8ae
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions tests/external_botocore/test_boto3_kinesis.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,11 @@
(f"Kinesis/delete_stream/{TEST_STREAM}", 1),
(f"External/{URL}/botocore/POST", 2),
]
if BOTOCORE_VERSION >= (1, 29, 0):
_kinesis_scoped_metrics.append((f"MessageBroker/Kinesis/Stream/Consume/Named/{TEST_STREAM}", 1))

_kinesis_rollup_metrics = [
(f"MessageBroker/Kinesis/Stream/Produce/Named/{TEST_STREAM}", 2),
(f"MessageBroker/Kinesis/Stream/Consume/Named/{TEST_STREAM}", 1),
(f"Kinesis/create_stream/{TEST_STREAM}", 1),
(f"Kinesis/describe_stream/{TEST_STREAM}", 1),
(f"Kinesis/get_shard_iterator/{TEST_STREAM}", 1),
Expand All @@ -65,6 +66,8 @@
(f"External/{URL}/all", 2),
(f"External/{URL}/botocore/POST", 2),
]
if BOTOCORE_VERSION >= (1, 29, 0):
_kinesis_rollup_metrics.append((f"MessageBroker/Kinesis/Stream/Consume/Named/{TEST_STREAM}", 1))

_kinesis_scoped_metrics_error = [
("MessageBroker/Kinesis/Stream/Produce/Named/Unknown", 1),
Expand Down Expand Up @@ -148,7 +151,10 @@ def test_kinesis():
)["ShardIterator"]

# Receive message
resp = client.get_records(ShardIterator=shard_iter, **stream_kwargs)
if BOTOCORE_VERSION < (1, 29, 0):
resp = client.get_records(ShardIterator=shard_iter)
else:
resp = client.get_records(ShardIterator=shard_iter, **stream_kwargs)
assert resp["ResponseMetadata"]["HTTPStatusCode"] == 200

# Delete stream
Expand Down

0 comments on commit 05af8ae

Please sign in to comment.