Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix flaky CustomEventWireModelTests #2978

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

tippmar-nr
Copy link
Member

Updated CustomEvents_UserAttributes_AllAttributeTypesSerializeCorrectly() (introduced yesterday) to make sure we use the same Jsonconverter for the "expected" serialization result. There was a slight difference in how DateTime values were being serialized without this change.

@tippmar-nr tippmar-nr requested a review from a team as a code owner January 31, 2025 19:57
@tippmar-nr tippmar-nr enabled auto-merge (squash) January 31, 2025 19:57
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (80d4c76) to head (b19622d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2978   +/-   ##
=======================================
  Coverage   82.18%   82.19%           
=======================================
  Files         473      473           
  Lines       30364    30364           
  Branches     3388     3388           
=======================================
+ Hits        24955    24957    +2     
+ Misses       4609     4606    -3     
- Partials      800      801    +1     
Flag Coverage Δ
Agent 83.17% <ø> (+<0.01%) ⬆️
Profiler 73.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@tippmar-nr tippmar-nr merged commit f7987c5 into main Jan 31, 2025
97 checks passed
@tippmar-nr tippmar-nr deleted the test/unit-test-fix branch January 31, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants