-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for instrumenting OpenSearchClient requests. #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full base class Working with tests.
tippmar-nr
reviewed
Jan 22, 2025
...gent/NewRelic/Agent/Extensions/NewRelic.Agent.Extensions/Helpers/SearchRequestWrapperBase.cs
Outdated
Show resolved
Hide resolved
tippmar-nr
reviewed
Jan 22, 2025
...gent/NewRelic/Agent/Extensions/NewRelic.Agent.Extensions/Helpers/SearchRequestWrapperBase.cs
Outdated
Show resolved
Hide resolved
tippmar-nr
reviewed
Jan 22, 2025
.../Agent/IntegrationTests/SharedApplications/Common/MFALatestPackages/MFALatestPackages.csproj
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2956 +/- ##
==========================================
+ Coverage 81.80% 81.92% +0.11%
==========================================
Files 470 471 +1
Lines 29953 30104 +151
Branches 3330 3348 +18
==========================================
+ Hits 24504 24663 +159
+ Misses 4657 4648 -9
- Partials 792 793 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tippmar-nr
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors Elasticsearch wrapper and adds OpenSearch wrapper. Both share the same base class. More could have been moved to the base class, but that code would not be testable so I left it in the wrappers. Some of the methods in the base could have been made private, but to cover more of the base class in unit tests I made them public. Integration tests are based on the Elasticsearh tests.
Author Checklist
Reviewer Checklist