Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for instrumenting OpenSearchClient requests. #2956

Merged
merged 10 commits into from
Jan 23, 2025

Conversation

jaffinito
Copy link
Member

Description

Refactors Elasticsearch wrapper and adds OpenSearch wrapper. Both share the same base class. More could have been moved to the base class, but that code would not be testable so I left it in the wrappers. Some of the methods in the base could have been made private, but to cover more of the base class in unit tests I made them public. Integration tests are based on the Elasticsearh tests.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@jaffinito jaffinito marked this pull request as ready for review January 22, 2025 18:55
@jaffinito jaffinito requested a review from a team as a code owner January 22, 2025 18:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (f622a40) to head (18d6435).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2956      +/-   ##
==========================================
+ Coverage   81.80%   81.92%   +0.11%     
==========================================
  Files         470      471       +1     
  Lines       29953    30104     +151     
  Branches     3330     3348      +18     
==========================================
+ Hits        24504    24663     +159     
+ Misses       4657     4648       -9     
- Partials      792      793       +1     
Flag Coverage Δ
Agent 82.88% <100.00%> (+0.12%) ⬆️
Profiler 73.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ent.Extensions/Helpers/SearchRequestWrapperBase.cs 100.00% <100.00%> (ø)
...ic.Agent.Extensions/Providers/Wrapper/Constants.cs 91.42% <ø> (ø)

... and 4 files with indirect coverage changes

@jaffinito jaffinito merged commit 4309938 into main Jan 23, 2025
96 checks passed
@jaffinito jaffinito deleted the other/opensearch branch January 23, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants