fix: fix flaky glob behavior with broken symlinks

newrelic-forks · Aug 26, 2020 · 57c0dfd · 57c0dfd
1 parent 5c0bf3a
commit 57c0dfd
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/file_system.js b/lib/file_system.js
@@ -93,7 +93,10 @@ class FileSystem {
     }
 
     // Remove all symlinks
-    return filePaths.filter(filePath => !onlySymlinks[this.normalizePath(filePath)])
+    const filtered = filePaths.filter(filePath => !onlySymlinks[this.normalizePath(filePath)])
+
+    // use lstat on the remaining to filter out broken symlinks
+    return (await Promise.all(filtered.map(async p => (await fs.promises.lstat(path.resolve(this.targetDir, p))).isSymbolicLink() ? null : p))).filter(p => p)
   }
 
   async glob (globs, options) {