Add named export for getDomElements #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it is accessible from the outside, at least useful to fully customize ConnectionWrapper. Also, kept it as default to not break anything.
|
Thank you! Feel free to push the change with named exports; I usually only use named exports that's also why I didn't check it when I added the export in the |
…lver Also, updated imports to remove default import usage.
|
Hey, it is pushed ! I ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the method is accessible from the outside, at least useful to fully customize ConnectionWrapper.
Also, kept it as default to not break anything.
It completes work done in #408.
Really tiny PR but I felt bad only commenting issues. Also it made me pretty sure I don't mess with anything ^^
If you want to do it your way, feel free to take or rework that change !
PS: I prepared changes to delete default export inside domResolver, to have only named exports. If you think it would be better, let me know so that I can push it.