Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external prop-types package #37

Closed
dmcclory opened this issue May 4, 2017 · 3 comments
Closed

Use external prop-types package #37

dmcclory opened this issue May 4, 2017 · 3 comments

Comments

@dmcclory
Copy link

dmcclory commented May 4, 2017

Hi!

I'm using react-stepzilla, but I'm encountering these warnings:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

They're pretty trivial, but they're messing up my CI runs.

I checked the source and noticed that stepzilla is importing PropTypes from react, which is in the process of being moved into that external package.

I can put up a PR if you'd like!

@newbreedofgeek
Copy link
Owner

newbreedofgeek commented May 4, 2017

@dmcclory the latest version of React moved PropTypes to its own package:
https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

I'll probably bump up the packages React version today and try and push a new version of StepZilla, stay tuned...

@newbreedofgeek
Copy link
Owner

newbreedofgeek commented May 5, 2017

@dmcclory I've upgraded to react 15.5.4 and pulled out PropTypes to use prop-types npm.

This should get rid of the warning messages now. Please let me know if you have any other issues.

New build has been published to npm, so make sure you update to v4.5.0

@newbreedofgeek
Copy link
Owner

@dmcclory closing as I've not heard anything and assume it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants