Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CI Tests are failing #306

Closed
MSNev opened this issue Aug 7, 2024 · 1 comment
Closed

[Bug] CI Tests are failing #306

MSNev opened this issue Aug 7, 2024 · 1 comment
Labels
blocking!! The issue is blocking the release process bug Something isn't working p1 Priority 1 published-npm
Milestone

Comments

@MSNev
Copy link
Contributor

MSNev commented Aug 7, 2024

The CI tests are failing with an apparent typo -- looks like an updated dependency issue as the same previously checked in code worked and did not have this issue.

07 08 2024 14:22:55.344:ERROR [preprocessor.rollup]: Failed to process ./lib/test/src/common/string/split.test.ts

RollupError: Expected ',', got ':'
at Object.getRollupError (/home/runner/work/ts-utils/ts-utils/node_modules/rollup/dist/shared/parseAst.js:282:41)
at ParseError.initialise (/home/runner/work/ts-utils/ts-utils/node_modules/rollup/dist/shared/rollup.js:12934:40)
at convertNode (/home/runner/work/ts-utils/ts-utils/node_modules/rollup/dist/shared/rollup.js:14630:10)
at convertProgram (/home/runner/work/ts-utils/ts-utils/node_modules/rollup/dist/shared/rollup.js:13974:12)
at Module.setSource (/home/runner/work/ts-utils/ts-utils/node_modules/rollup/dist/shared/rollup.js:15788:24)
at async ModuleLoader.addModuleSource (/home/runner/work/ts-utils/ts-utils/node_modules/rollup/dist/shared/rollup.js:20101:13)

@MSNev MSNev added bug Something isn't working p1 Priority 1 blocking!! The issue is blocking the release process labels Aug 7, 2024
@MSNev MSNev added this to the 0.11.4 milestone Aug 7, 2024
@nev21
Copy link
Contributor

nev21 commented Sep 3, 2024

After lots of investigation this has been narrowed done to an issue with using chai assertions and karma ONLY running in a Web Worker. I've trialed several options and simply replacing chai (using a local beta of tripwire assertions resolves the issue, as such I've accelerated to conversion of this library into something public and can be published to GitHub).

It's taking longer than expected to make sure that it can be more easily extensible than the original internal version, but planning on releasing an early (incomplete) version shortly to unblock these projects.

nev21 added a commit that referenced this issue Sep 21, 2024
- Update to tripwire-chai shim from chai
nev21 added a commit that referenced this issue Sep 21, 2024
- Update to tripwire-chai shim from chai
nev21 added a commit that referenced this issue Sep 21, 2024
- Update to tripwire-chai shim from chai
@nev21 nev21 closed this as completed Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking!! The issue is blocking the release process bug Something isn't working p1 Priority 1 published-npm
Projects
None yet
Development

No branches or pull requests

2 participants