-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Tree-Shaking is not working properly #230
Comments
Issue is still occurring for some "other" usages, specifically in ApplicationInsights for the var strSplit = _unwrapFunction("split", StrProto);
hasSymbol() ? _unwrapFunction("split", StrProto) : polyStrSymSplit; Trialing some local "fixes", it's possible to suppress this further by tagging the |
Please add this to all of the "accessor" functions like |
- By tagging isNode() as no side-effects (which is doesn't have) causes rollup to agressively remove it from a non-node build, which results in bundles that don't work for all environments. - So untagging
…236) - By tagging isNode() as no side-effects (which is doesn't have) causes rollup to agressively remove it from a non-node build, which results in bundles that don't work for all environments. - So untagging
Describe the bug
Consuming the latest version of the library
0.10.2
results in the following code being left behind in@nevware21/ts-async
Where the
LAST_INDEX_OF
(which is not used), is not getting tree-shaken from the buildTo Reproduce
Steps to reproduce the behavior:
dist/es5/amd/ts-async.js
(actually most of the formats not justamd
)Expected behavior
The unused functions should get tree-shaken out of existence in the consuming modules
The text was updated successfully, but these errors were encountered: