Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: use event delegation #319

Merged
merged 20 commits into from
Oct 24, 2017
Merged

Performance: use event delegation #319

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3420269
Add data-type to elements
Indigo744 Oct 2, 2017
c4438e6
Delegate all mouseover/mousemove/mouseleave events
Indigo744 Oct 2, 2017
3016553
Delegate click events
Indigo744 Oct 2, 2017
dc417de
Fix typo
Indigo744 Oct 2, 2017
e1c7ebb
Set better data-type for legend elems and canvas
Indigo744 Oct 2, 2017
67f6cd1
Run delegated events on container (to also handle legends)
Indigo744 Oct 2, 2017
c5011c5
Store all generated legends
Indigo744 Oct 2, 2017
209b044
Set legends as mapElem / textElem
Indigo744 Oct 2, 2017
c972935
Event delegation mouseover/mousemove/mouseout for legends
Indigo744 Oct 2, 2017
8f3ba39
No event filtering for click events
Indigo744 Oct 2, 2017
331a93a
self.legends uses legendType
Indigo744 Oct 2, 2017
ecc133a
Event delegation for legend click
Indigo744 Oct 2, 2017
74f5d97
Fix tests
Oct 3, 2017
35eaed4
Implements delegation for custom events
Indigo744 Oct 6, 2017
61812c7
Add space between () and {
Indigo744 Oct 10, 2017
c01dde6
Merge branch 'master' of https://github.com/neveldo/jQuery-Mapael int…
Indigo744 Oct 10, 2017
596cd4b
Reduce settimeout value for tooltips hover to avoid jerkiness
Indigo744 Oct 10, 2017
a4b473f
Simplify event delegation computation function
Indigo744 Oct 10, 2017
258043a
Merge branch 'master' of https://github.com/neveldo/jQuery-Mapael int…
Indigo744 Oct 11, 2017
ded2138
Merge branch 'master' of https://github.com/Indigo744/jQuery-Mapael i…
Indigo744 Oct 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions js/jquery.mapael.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1927,8 +1927,6 @@

/* Handle tooltip position update */
if (elem.tooltip !== undefined) {
console.log(elem);

var mouseX = event.pageX;
var mouseY = event.pageY;

Expand All @@ -1954,7 +1952,7 @@
if (elem.tooltip.overflow.right === true) {
tooltipPosition.left = mouseX - self.$map.offset().left + 10;
}
if (selem.tooltip.overflow.bottom === true) {
if (elem.tooltip.overflow.bottom === true) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you have fixed this typo twice ;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahah yes indeed!

tooltipPosition.top = mouseY - self.$map.offset().top + 20;
}
}
Expand Down