Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve div generation when yet set #23

Closed
wants to merge 1 commit into from

Conversation

camlafit
Copy link

@camlafit camlafit commented Jan 8, 2014

  • Get only ones tooltip, zoomIn, zoomOut div
  • This behaviour can occure when a new map is loaded and try to override previous map loaded

* Get only ones tooltip, zoomIn, zoomOut div
* This behaviour can occure when a new map is loaded and try to override previous map loaded
@neveldo
Copy link
Owner

neveldo commented Jan 19, 2014

Hello,

Could you provide an example where the problem occurs ?

The tooltip zoomIn and zoomOut divs shouldn't be created twice when a map is created over another because the container is emptied first.

@camlafit
Copy link
Author

Hi

I display in same block differents maps. Each map call same mapael function $("#mapsvg").mapael(); arguments are set by click action.
In this case, map content don't look emptied first.

@neveldo
Copy link
Owner

neveldo commented Jan 23, 2014

Hi,

The map content is not empty, but at the line 23, $container is emptied with a call to empty(). Could you show me an online example of the issue you encountered ? (with JSFiddle for example)

@camlafit
Copy link
Author

Hi

I must rewrite my code as I use raphael on mine scripts.

@Indigo744
Copy link
Collaborator

Assigning a new map on an existing one (i.e. overriding) will be taken care thanks to the new architecture (#117) and the work on leaking problems (#118).

@Indigo744 Indigo744 closed this Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants