Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev version format and pip install in github actions #6

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Feb 21, 2025

Short description of the changes:

pip install -e . in github actions
dev version PEP 440-compliant.
next version method update

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

pip instal -e .
inspired--version
should print 0.3.1.devxxxx

References

@mpatrou mpatrou changed the title Pip install in github actions Dev version format and pip install in github actions Feb 21, 2025
@KyleQianliMa KyleQianliMa self-requested a review February 21, 2025 21:09
Copy link

@KyleQianliMa KyleQianliMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok this is just installing in editable mode.

@mpatrou mpatrou merged commit d0a8a0f into next Feb 21, 2025
1 check passed
@mpatrou mpatrou deleted the pip_install_g_action branch February 21, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants