Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda package lib inclusion #9

Merged
merged 10 commits into from
Feb 19, 2025
Merged

Conda package lib inclusion #9

merged 10 commits into from
Feb 19, 2025

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Feb 17, 2025

Short description of the changes:

Changes related to the creation of conda package. A build script is introduced

Long description of the changes:

  • build script that includes the lib/, src/ and bin/plothist files as the mcvine: histogram. The creation of a shared library in comments, in case it is needed in the future.
  • updates in meta.yaml related to the script
  • updates in pyproject.toml for depedencies
  • Histogram.py fix for units
  • action update for checking the wheel

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

To test follow the instructions for building the wheel and the conda package locally and then installing it: https://github.com/neutrons/histogram-dev?tab=readme-ov-file#installation

References

Include the files inside lib/ in the conda package

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (dbc91e0) to head (0a4f8d3).

Additional details and impacted files
@@            Coverage Diff             @@
##             next       #9      +/-   ##
==========================================
+ Coverage   78.71%   78.76%   +0.05%     
==========================================
  Files          59       59              
  Lines        3523     3523              
==========================================
+ Hits         2773     2775       +2     
+ Misses        750      748       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterfpeterson
Copy link
Member

The conda package gave a warning

[C1141] Found python file "site-packages/histogram/DatasetBase.py" without a corresponding pyc file

which suggests that something is a tiny bit off with the pyproject.toml

@mpatrou
Copy link
Collaborator Author

mpatrou commented Feb 19, 2025

we do not include the pyc files explicitly in the package.

@mpatrou mpatrou merged commit f5b59c1 into next Feb 19, 2025
3 checks passed
@mpatrou mpatrou deleted the conda_pkg_lib branch February 19, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants