forked from danse-inelastic/histogram
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda package lib inclusion #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #9 +/- ##
==========================================
+ Coverage 78.71% 78.76% +0.05%
==========================================
Files 59 59
Lines 3523 3523
==========================================
+ Hits 2773 2775 +2
+ Misses 750 748 -2 ☔ View full report in Codecov by Sentry. |
peterfpeterson
requested changes
Feb 18, 2025
The conda package gave a warning
which suggests that something is a tiny bit off with the |
we do not include the pyc files explicitly in the package. |
peterfpeterson
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes:
Changes related to the creation of conda package. A build script is introduced
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
To test follow the instructions for building the wheel and the conda package locally and then installing it: https://github.com/neutrons/histogram-dev?tab=readme-ov-file#installation
References
Include the files inside lib/ in the conda package