-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda Package #5
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #5 +/- ##
==========================================
+ Coverage 54.45% 54.64% +0.19%
==========================================
Files 15 15
Lines 2301 2313 +12
==========================================
+ Hits 1253 1264 +11
- Misses 1048 1049 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good, builds as expected and all tests pass. Just check to make sure we still need oncat and clean-up if no longer needed.
- versioningit | ||
|
||
run: | ||
- pyoncat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still required? I don't see it used anywhere in the repo?
@@ -4,15 +4,23 @@ channels: | |||
- mantid/label/nightly | |||
- oncat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyoncat is not being installed in the environment and is not used. Can this be removed?
channels: | ||
- conda-forge | ||
- mantid/label/nightly | ||
- oncat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we still need this channel.
channels: | ||
- conda-forge | ||
- mantid/label/nightly | ||
- oncat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follows same practice as other repositories in the project and builds conda package as expected.
Short description of the changes:
The code adds the ability to create a conda package and deploy on anaconda registry through github runner.
Long description of the changes:
to test run pytest
to test everything on analysis cluster run pytest --all
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References