Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda Package #5

Merged
merged 24 commits into from
Jun 10, 2024
Merged

Conda Package #5

merged 24 commits into from
Jun 10, 2024

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Jun 6, 2024

Short description of the changes:

The code adds the ability to create a conda package and deploy on anaconda registry through github runner.

Long description of the changes:

  • Conda package configuration
  • github runner for anaconda
  • updates in github runners to use micromamba with channels and cached environment. (there was a warning with the previous way with the conda-incubator for the cached section)
  • workflow/main function restructure
  • test added for main function

to test run pytest
to test everything on analysis cluster run pytest --all

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.64%. Comparing base (24f1954) to head (3de53d6).

Files Patch % Lines
src/garnet/reduction/version.py 0.00% 2 Missing ⚠️
src/garnet/workflow.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next       #5      +/-   ##
==========================================
+ Coverage   54.45%   54.64%   +0.19%     
==========================================
  Files          15       15              
  Lines        2301     2313      +12     
==========================================
+ Hits         1253     1264      +11     
- Misses       1048     1049       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@searscr searscr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, builds as expected and all tests pass. Just check to make sure we still need oncat and clean-up if no longer needed.

- versioningit

run:
- pyoncat
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still required? I don't see it used anywhere in the repo?

@@ -4,15 +4,23 @@ channels:
- mantid/label/nightly
- oncat
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyoncat is not being installed in the environment and is not used. Can this be removed?

channels:
- conda-forge
- mantid/label/nightly
- oncat
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we still need this channel.

channels:
- conda-forge
- mantid/label/nightly
- oncat
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link

@searscr searscr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follows same practice as other repositories in the project and builds conda package as expected.

@mpatrou mpatrou merged commit d21cfe7 into next Jun 10, 2024
3 checks passed
@mpatrou mpatrou deleted the conda_pkg branch June 10, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants