Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest, Existing GitLfs garnet-data repo connection and Code Coverage Initialization #4

Merged
merged 23 commits into from
Jun 4, 2024

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Jun 3, 2024

Short description of the changes:

Updates in tests, pytest, codecoverage and garnet-data existing repository configurations

Long description of the changes:

  • Failing tests are fixed
  • Temporary directories from pytest used in every test
  • Artifact organization
  • mount_sns, mount_hfir and resources_intensive marker added.
  • pytest --all runs all tests, pytest runs all test expet from resources_intensive
  • CI for pytest and code coverage enabled
  • existing gitlfs data repository: https://code.ornl.gov/sns-hfir-scse/infrastructure/test-data/garnet-data is connected to this one. The data repository was originally created for neutron garnet repository (front and back end), but it is not used. Existing marker, test and configurations taken from garnet repository

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

pytest --all : executes all tests
pytest: skips the resource intensive

hfir and sns mounts are necessary for some tests

References

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@mpatrou mpatrou changed the title Pytest and Coverage Initialization Pytest and Code Coverage Initialization Jun 3, 2024
@mpatrou mpatrou changed the title Pytest and Code Coverage Initialization Pytest, Existing GitLfs garnet-data repo connection and Code Coverage Initialization Jun 3, 2024
@mpatrou mpatrou merged commit 082a603 into next Jun 4, 2024
2 checks passed
@mpatrou mpatrou deleted the pytest_init branch June 4, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants