Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-tune automated TOF range selection #128

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Fine-tune automated TOF range selection #128

merged 2 commits into from
Jul 29, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Jul 29, 2024

Fine-tune the TOF range selection.

@mdoucet mdoucet requested a review from backmari July 29, 2024 15:09
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 60.43%. Comparing base (54e082c) to head (1fe7356).
Report is 2 commits behind head on next.

Files Patch % Lines
RefRed/calculations/lr_data.py 30.00% 7 Missing ⚠️
RefRed/sf_calculator/lr_data.py 30.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #128      +/-   ##
==========================================
- Coverage   60.49%   60.43%   -0.06%     
==========================================
  Files         121      121              
  Lines       10137    10149      +12     
==========================================
+ Hits         6132     6134       +2     
- Misses       4005     4015      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested that the automated TOF range selection works as expected for run 210487:

Screenshot from 2024-07-29 13-26-09

@mdoucet mdoucet merged commit bb47a16 into next Jul 29, 2024
3 checks passed
@mdoucet mdoucet deleted the fix_tof_range branch July 29, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants