Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove functional background from background settings #115

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

backmari
Copy link
Collaborator

Short description of the changes:

Remove functional background from background settings. The backend lr_reduction will make the decision about functional background depending on whether the option to use two backgrounds is active or not.

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

Open the background settings in the UI and check that the functional background is removed and the remaining options work as before.

References

Defect 4326: [REFRED] Eliminate "functional background" from the background settings

@backmari backmari force-pushed the remove_functional_background branch from ab03d25 to bf811b3 Compare March 18, 2024 12:41
@backmari backmari force-pushed the remove_functional_background branch from bf811b3 to 35d3dba Compare March 18, 2024 14:49
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@backmari backmari merged commit 8ec3321 into next Mar 18, 2024
3 checks passed
@backmari backmari deleted the remove_functional_background branch March 18, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants