Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: burn fees or send to treasury #NTRN-300 #117

Merged
merged 5 commits into from
Jan 13, 2023
Merged

feat: burn fees or send to treasury #NTRN-300 #117

merged 5 commits into from
Jan 13, 2023

Conversation

foxpy
Copy link
Contributor

@foxpy foxpy commented Dec 26, 2022 •
edited
Loading

pr0n00gler
pr0n00gler requested changes Dec 26, 2022
View reviewed changes
Copy link
Collaborator

@pr0n00gler pr0n00gler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you decide to split fees manually in the ante handler, and not use already split amount of consumer fees here and do all the work in EndBlocker?

Sorry, it should be a comment, not request changes

@foxpy
Copy link
Contributor Author

foxpy commented Dec 26, 2022

Why did you decide to split fees manually in the ante handler, and not use already split amount of consumer fees here and do all the work in EndBlocker?

Simplified that part 👍

@foxpy foxpy force-pushed the feat/NTRN-300-burn-fee-send-to-treasury branch from 54b6c04 to 9a06c17 Compare December 27, 2022 06:38
@foxpy foxpy mentioned this pull request Dec 27, 2022
Merged
albertandrejev
albertandrejev reviewed Dec 28, 2022
View reviewed changes
proto/feeburner/query.proto Outdated Show resolved Hide resolved
x/feeburner/client/cli/query_total_burned_neutrons.go Outdated Show resolved Hide resolved
x/feeburner/types/params.go Outdated Show resolved Hide resolved
proto/feeburner/params.proto Outdated Show resolved Hide resolved
proto/feeburner/tx.proto Outdated Show resolved Hide resolved
x/feeburner/client/cli/tx.go Outdated Show resolved Hide resolved
proto/feeburner/params.proto Outdated Show resolved Hide resolved
@quasisamurai quasisamurai mentioned this pull request Jan 8, 2023
Merged
zavgorodnii
zavgorodnii reviewed Jan 9, 2023
View reviewed changes
x/feeburner/module.go Outdated Show resolved Hide resolved
albertandrejev
albertandrejev reviewed Jan 9, 2023
View reviewed changes
x/feeburner/module.go Outdated Show resolved Hide resolved
x/feeburner/module.go Outdated Show resolved Hide resolved
@albertandrejev albertandrejev mentioned this pull request Jan 10, 2023
Merged
@foxpy foxpy mentioned this pull request Jan 10, 2023
Merged
@foxpy foxpy force-pushed the feat/NTRN-300-burn-fee-send-to-treasury branch from e6b1c43 to 3ae5577 Compare January 10, 2023 17:22
@foxpy foxpy changed the title WIP feat: burn fee send to treasury #NTRN-300 feat: burn fee send to treasury #NTRN-300 Jan 10, 2023
@foxpy foxpy marked this pull request as ready for review January 10, 2023 17:23
@foxpy foxpy changed the title feat: burn fee send to treasury #NTRN-300 feat: burn fees or send to treasury #NTRN-300 Jan 10, 2023
@foxpy foxpy force-pushed the feat/NTRN-300-burn-fee-send-to-treasury branch from 3ae5577 to 10a0a87 Compare January 10, 2023 17:40
albertandrejev
albertandrejev previously approved these changes Jan 12, 2023
View reviewed changes
zavgorodnii
zavgorodnii previously approved these changes Jan 12, 2023
View reviewed changes
@foxpy foxpy dismissed stale reviews from zavgorodnii and albertandrejev via a45c5e0 January 12, 2023 16:10
@foxpy foxpy force-pushed the feat/NTRN-300-burn-fee-send-to-treasury branch from 7de273b to a45c5e0 Compare January 12, 2023 16:10
pr0n00gler
pr0n00gler previously approved these changes Jan 12, 2023
View reviewed changes
@pr0n00gler pr0n00gler merged commit 84e862a into main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pr0n00gler pr0n00gler pr0n00gler approved these changes

@albertandrejev albertandrejev albertandrejev approved these changes

@zavgorodnii zavgorodnii Awaiting requested review from zavgorodnii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foxpy @albertandrejev @zavgorodnii @pr0n00gler