Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/proposal tests NTRN-340 #38

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Feat/proposal tests NTRN-340 #38

merged 3 commits into from
Mar 13, 2023

Conversation

quasisamurai
Copy link
Contributor

@quasisamurai quasisamurai commented Feb 17, 2023 •
edited
Loading

TASK

No need to test, GitHub does it automatically

@quasisamurai quasisamurai changed the base branch from main to neutron_audit_informal_17_01_2023 February 17, 2023 10:52
@quasisamurai quasisamurai marked this pull request as ready for review February 17, 2023 10:53
zavgorodnii
zavgorodnii requested changes Mar 9, 2023
View reviewed changes
contracts/dao/proposal/cwd-proposal-multiple/src/testing/instantiate.rs Outdated
}
}

// fn _get_default_token_dao_proposal_module_instantiate(app: &mut App) -> InstantiateMsg {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code

contracts/dao/proposal/cwd-proposal-multiple/src/testing/instantiate.rs Outdated
core_addr
}

// pub fn _instantiate_with_cw4_groups_governance(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code

packages/cwd-testing/src/contracts.rs Outdated
Box::new(contract)
}

// pub fn native_staked_balances_voting_contract() -> Box<dyn Contract<Empty>> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code

@zavgorodnii zavgorodnii merged commit be28ca7 into neutron_audit_informal_17_01_2023 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zavgorodnii zavgorodnii zavgorodnii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quasisamurai @zavgorodnii