-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardening overrule proposals with additional checks #NTRN-325 #32
Merged
Merged
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
92ba326
wip
oldremez 6413f49
wip
oldremez 7d40f0c
wip
oldremez ee32d0a
messages refactoring
oldremez b73035f
temp commit
oldremez 99603e3
query and config fixes
oldremez 3257032
Merge branch 'neutron_audit_informal_17_01_2023' into feat/subdao-reg…
oldremez 959bd60
wip
oldremez 0570481
Merge branch 'neutron_audit_informal_17_01_2023' into feat/subdao-reg…
oldremez fb4ba65
most of the code is written
oldremez 09f4917
positive test scenario pass
oldremez 779bb0b
refactoring
oldremez 794ac50
wip
oldremez 7b66d5f
huge refactoring, overrule creation added, more tests
oldremez d3bb5c1
massive unit tests refactoring
oldremez 8433023
overrule pre propose tests pass
oldremez 06e1082
cleaning up some stuff
oldremez eb2388f
queries tests
oldremez 8857a2c
QueryBase -> QueryExt
oldremez 2c810b4
overrule proposal id query test
oldremez aab8ff0
fixing timelock tests wip
oldremez 78159ae
timelock fixes and tests
oldremez a881fcb
schema fixes
oldremez ff6776f
clippy fixes
oldremez 598b609
schema regen
oldremez 51d7ef6
refactoring
oldremez c0def32
fix imports to make release build pass
oldremez 2c69309
clippy fixes
oldremez b21d9d4
init msg fix
oldremez 53df446
Merge branch 'main' into feat/subdao-registry
oldremez 3192ee0
fix
oldremez cc5e3ec
removing redundant deps
oldremez f55bf39
timelock proposal tracks the overrule proposal status now
oldremez 8f15c55
rustfmt
oldremez ad531cb
return commented tests
oldremez 501cbea
clippy
oldremez ff3f197
fmt
oldremez ba6ad37
redundant deps
oldremez bb4cbb3
fixed proposalresponse
oldremez 4b8b946
fixed preproposal hooks
oldremez 82147dd
fmt
oldremez 2dc5f6e
clippy
oldremez 4076475
Merge branch 'main' into feat/subdao-registry
oldremez 3036155
Merge branch 'main' into feat/subdao-registry
oldremez 7d8dd6f
housekeeping
oldremez 1a56936
error descriptions
oldremez 8dd178e
more error descriptions
oldremez 430ffe0
fmt
oldremez 3ee3cab
refactoring+comments
oldremez 9841bb0
format fix
oldremez d2a1fd6
tests fix
oldremez 2b825b4
Merge branch 'main' into feat/subdao-registry
oldremez c63fad0
post-review error descriptions fixes
oldremez 9fd4d73
post-review refactoring
oldremez 0675ea3
post-review fmt
oldremez 6f8dcfd
post-review refactoring
oldremez 2d08e28
post-review get subdao query
oldremez d3b0160
post-review fmt
oldremez 03421cc
post-review clippy
oldremez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
post-review refactoring
- Loading branch information
commit 6f8dcfdd34eed7849e507b85b5873d04c676cc0d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already &String
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the argument type to Addr for consistency reasons