Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: subdao timelocks impl tests #NTRN-320 #21

Merged
merged 4 commits into from
Jan 8, 2023
Merged

feat: subdao timelocks impl tests #NTRN-320 #21

merged 4 commits into from
Jan 8, 2023

Conversation

swelf19
Copy link
Contributor

@swelf19 swelf19 commented Dec 28, 2022

No description provided.

@swelf19 swelf19 force-pushed the feat/subdao-timelocks-impl-tests branch from 069c338 to 17e41fc Compare December 29, 2022 12:03
@swelf19 swelf19 marked this pull request as ready for review December 29, 2022 12:09
quasisamurai
quasisamurai approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@quasisamurai quasisamurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testedACK

@swelf19 swelf19 changed the title feat: subdao timelocks impl tests feat: subdao timelocks impl tests #NTRN-320 Dec 29, 2022
@zavgorodnii
Copy link
Contributor

Note: the subdaos/voting/* cw4-voting contract is a vanilla voting contract, no changes were introduced. We can safely get rid of it.

Merging this PR (cargo test succussfully passes).

$ git log -- contracts/subdaos/voting/*
commit e0cba582397255965317ce653ea0a6d7e84389b4 (origin/feat/subdao-timelocks, feat/subdao-timelocks)
Author: quasisamurai <quazisamurai@gmail.com>
Date:   Fri Dec 16 19:56:37 2022 +0400

    add voting module

@zavgorodnii zavgorodnii merged commit db73a61 into feat/subdao-timelocks-impl Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasisamurai quasisamurai quasisamurai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swelf19 @zavgorodnii @quasisamurai