-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/proposal multiple #NTRN-311 #17
Conversation
c43d927
to
b4c38e9
Compare
There is quite a lot of code (more than 1000 LoC) to review, could you please describe what deserves the most of our attention? |
it would be a nice idea to have a pr to neutron which will include this contact in genesis. as well as have some simple tests, at least |
@foxpy The most attention is required by contracts code. There are two of them - cwd_pre_propose_multiple and cwd_proposal_multiple. You can test it by:
|
Any updates on the this? |
832354e
to
3aefb4b
Compare
731d5a6
to
34a7da8
Compare
|
||
|
||
# PROPOSAL 2 (to pick "none of the above" option) | ||
#propose proposal we're going to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#propose proposal we're not going to pass
Implements this task
https://github.com/neutron-org/neutron-tests/actions/runs/3873343559
Adds cwd-pre-propose-multiple and cwd-proposal-multiple contracts to handle multi choice proposals.
Originally is a copypaste from
48d9629
commit from https://github.com/DA0-DA0/dao-contractsOnly changes are:
Empty
generics was removed (analogous to proposal-single contracts: