Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admonition rendering in README #95

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix admonition rendering in README #95

merged 1 commit into from
Dec 6, 2023

Conversation

niksirbi
Copy link
Member

@niksirbi niksirbi commented Dec 6, 2023

The admonitions (Note and Warning) on the GitHub README were not rendering properly, because I had used an unsupported syntax. I've fixed them so that they render correctly.

Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64125db) 98.51% compared to head (9ec2a69) 98.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files           8        8           
  Lines         403      403           
=======================================
  Hits          397      397           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niksirbi niksirbi marked this pull request as ready for review December 6, 2023 09:53
@niksirbi niksirbi requested a review from lochhh December 6, 2023 09:53
Copy link
Collaborator

@lochhh lochhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM1

@lochhh lochhh merged commit cc35888 into main Dec 6, 2023
24 checks passed
@lochhh lochhh deleted the readme-admonitions branch December 6, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants