Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading "trackless" SLEAP files #90

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

lochhh
Copy link
Collaborator

@lochhh lochhh commented Nov 23, 2023

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
This PR enables SLEAP files (.h5 and .slp) without Tracks to be loaded.

What does this PR do?

References

This PR resolves #89

How has this PR been tested?

Relevant tests have been added and run

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e12f08) 98.34% compared to head (37670ad) 98.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   98.34%   98.37%   +0.03%     
==========================================
  Files           8        8              
  Lines         362      369       +7     
==========================================
+ Hits          356      363       +7     
  Misses          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lochhh lochhh requested a review from niksirbi November 23, 2023 19:27
@lochhh lochhh marked this pull request as ready for review November 23, 2023 19:27
@niksirbi niksirbi mentioned this pull request Nov 24, 2023
7 tasks
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I also tested in on the sample data for the course, and it works!

movement/io/load_poses.py Show resolved Hide resolved
@lochhh lochhh merged commit 88b23de into main Nov 24, 2023
24 checks passed
@lochhh lochhh deleted the load-sleap-no-track branch November 24, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reading SLEAP files without Tracks
2 participants