-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] - Plot updates & extensions #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I added a few optional comments. Something to think about for the future though is a separate plotting package the signals/psds, as the plotting functionality here grows.
Thanks for checking @ryanhammonds! I made some updates based on your comments, if you want to check the update for the multi plot in particular (since what the API for that should be is not so obvious). And yeh, I agree - as things grow, we should definitely consider "what belongs where" and if/when we might consider splitting things out from ndsp. I've been meaning to do a proper sweep of code for a bit, so maybe let's check in on this sometime soon, as we check in on what goes into 2.3, what goes after, and any things we need to figure out on the roadmap otherwise. |
Some additions & tweaks to plotting including:
plot_style
The upshot of the style update is that something like this now works:
Note: the tests on newer versions of python were failing on a doctest, where an answer that used to come out at 2.0 is now 2.000000000000026 (or something) - so I added rounding to this check.