Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Remove ort from transformers dependency #1976

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

rahul-tuli
Copy link
Member

Now that ORT is not "required" by transformers explicitly unless validate_correctness is called this PR does two things:

  • Remove ort from transformers dependency
  • Raise apt install message when ort is used

raise apt install message when ort is used
@rahul-tuli rahul-tuli requested review from Satrat, bfineran, dsikka, horheynm and dbogunowicz and removed request for Satrat January 18, 2024 21:45
@rahul-tuli rahul-tuli self-assigned this Jan 18, 2024
@rahul-tuli rahul-tuli added the bug Something isn't working label Jan 18, 2024
@rahul-tuli rahul-tuli merged commit 759407e into main Jan 18, 2024
13 checks passed
@rahul-tuli rahul-tuli deleted the remove-ort-from-transformers-dep branch January 18, 2024 21:53
rahul-tuli added a commit that referenced this pull request Jan 19, 2024
raise apt install message when ort is used
@rahul-tuli rahul-tuli mentioned this pull request Jan 19, 2024
10 tasks
rahul-tuli added a commit that referenced this pull request Jan 22, 2024
raise apt install message when ort is used
bfineran pushed a commit that referenced this pull request Jan 22, 2024
raise apt install message when ort is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants