Skip to content

Commit

Permalink
minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
rahul-tuli committed Jan 11, 2024
1 parent 3223770 commit b8f53aa
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions src/sparseml/core/logger/logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -870,11 +870,12 @@ def log_ready(
"""
log_enabled = any(logger.enabled for logger in self.loggers)
if last_log_step is not None:
self.warning(
tag="warning",
string="specifying `last_log_step` is now deprecated "
warnings.warn(
message="specifying `last_log_step` is now deprecated "
"and will be removed in a future release. Update to use"
" `log_written(step)` to track the last log step",
category=DeprecationWarning,
stacklevel=2,
)
self.frequency_manager.log_written(step=last_log_step)

Expand Down Expand Up @@ -986,7 +987,7 @@ def log_scalar(
def log_scalars(
self,
tag: str,
values: float,
values: Dict[str, float],
step: Optional[int] = None,
wall_time: Optional[float] = None,
log_types: Union[str, List[str]] = ALL_TOKEN,
Expand Down Expand Up @@ -1100,13 +1101,13 @@ class LoggingWrapperBase:
"""

def __init__(self, loggers: List[BaseLogger], frequency_manager: FrequencyManager):
self._loggers = loggers
self.loggers = loggers
self._frequency_manager = frequency_manager

def __repr__(self):
return (
f"{self.__class__.__name__}("
f"loggers={self._loggers}, frequency_manager={self._frequency_manager})"
f"loggers={self.loggers}, frequency_manager={self._frequency_manager})"
)


Expand Down Expand Up @@ -1241,7 +1242,7 @@ def log_hyperparams(
:param params: Each key-value pair in the dictionary is the name of the
hyper parameter and it's corresponding value.
"""
for log in self._loggers:
for log in self.loggers:
if log.enabled and (log_types == ALL_TOKEN or log.name in log_types):
log.log_hyperparams(params, level)

Expand Down Expand Up @@ -1275,7 +1276,7 @@ def log_scalar(
def log_scalars(
self,
tag: str,
values: float,
values: Dict[str, float],
step: Optional[int] = None,
wall_time: Optional[float] = None,
log_types: Union[str, List[str]] = ALL_TOKEN,
Expand Down

0 comments on commit b8f53aa

Please sign in to comment.